[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855349#comment-13855349
]
Ted Yu commented on HBASE-7226:
-------------------------------
lgtm
nit: long line:
{code}
+ // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2,
succeed (value still = val2)
{code}
> HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=
> ---------------------------------------------------------------------------
>
> Key: HBASE-7226
> URL: https://issues.apache.org/jira/browse/HBASE-7226
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Feng Honghua
> Assignee: Feng Honghua
> Fix For: 0.94.16
>
> Attachments: HBASE-7226-trunk.patch, HRegion_HBASE_7226_0.94.2.patch
>
>
> in HRegion.checkAndMutate, incorrect comparison results are used for <, <=, >
> and >=, as below:
> switch (compareOp) {
> case LESS:
> matches = compareResult <= 0; // should be '<' here
> break;
> case LESS_OR_EQUAL:
> matches = compareResult < 0; // should be '<=' here
> break;
> case EQUAL:
> matches = compareResult == 0;
> break;
> case NOT_EQUAL:
> matches = compareResult != 0;
> break;
> case GREATER_OR_EQUAL:
> matches = compareResult > 0; // should be '>=' here
> break;
> case GREATER:
> matches = compareResult >= 0; // should be '>' here
> break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
