[ https://issues.apache.org/jira/browse/HBASE-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu reassigned HBASE-10224: ------------------------------ Assignee: Ted Yu > Line length check in test-patch.sh is broken > -------------------------------------------- > > Key: HBASE-10224 > URL: https://issues.apache.org/jira/browse/HBASE-10224 > Project: HBase > Issue Type: Test > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 10176-v1.txt > > > Here is related code in the script: > {code} > MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1` > ... > ll=`echo "$lines" | wc -l` > if [[ "$ll" -gt "$MAX_LINE_LENGTH_PATCH" ]]; then > {code} > Here was the result from dry run: > {code} > TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep "^+" | > grep -v "^@@" | grep -v "^+++" | grep -v "import" | grep -v > "hbase.protobuf.generated" | awk -v len="101" 'length ($0) > len' | head -n > 10` > TYus-MacBook-Pro:m7 tyu$ ll=`echo "$lines" | wc -l` > TYus-MacBook-Pro:m7 tyu$ echo $ll > 3 > TYus-MacBook-Pro:m7 tyu$ echo $lines > + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, > succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = > val2, compare with val1, succeed (now value = val3) + // Test > CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed > (value still = val2) > {code} > The value of $ll should be compared with 0, not the value of > $MAX_LINE_LENGTH_PATCH -- This message was sent by Atlassian JIRA (v6.1.5#6160)