[
https://issues.apache.org/jira/browse/HBASE-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860981#comment-13860981
]
Ted Yu commented on HBASE-9858:
-------------------------------
Typo - should be hyphen:
{code}
+ public static final char HIPHON = '-';
{code}
{code}
- int colsPerKey, int recordSize, int writeThreads, boolean useTags, int
maxTagsPerKey) throws Exception {
+ protected void runIngestTest(long defaultRunTime, int keysPerServerPerIter,
int colsPerKey,
+ int recordSize, int writeThreads) throws Exception {
{code}
The last two parameters are removed because they're not used ?
{code}
+ private static final String[] VISIBILITY_EXPS = { "secret & confidential &
!private",
+ "topsecret | confidential", "confidential & private", "public",
"topsecret & private" };
{code}
Can you add expression involving '|' and '!' at the same time ?
{code}
+public class LoadTestDataGeneratorWithVisibilityLabels extends
DefaultDataGenerator {
{code}
Mind adding annotation for audience ?
Same for this class:
{code}
+public class LoadTestDataGeneratorWithTags extends DefaultDataGenerator {
{code}
{code}
+ throw new IllegalArgumentException("LoadTestDataGeneratorWithTags must
have "
+ + "4 initialization arguments");
{code}
Mind adding short description of what purpose the 4 arguments serve ?
{code}
+ public void start(long startKey, long endKey, int numThreads) throws
IOException {
+ super.start(startKey, endKey, numThreads);
{code}
nit: indentation
> Integration test and LoadTestTool support for cell Visibility
> -------------------------------------------------------------
>
> Key: HBASE-9858
> URL: https://issues.apache.org/jira/browse/HBASE-9858
> Project: HBase
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.98.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.98.0
>
> Attachments: HBASE-9858.patch, HBASE-9858_V2.patch
>
>
> Cell level visibility should have an integration test and LoadTestTool
> support.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
