[
https://issues.apache.org/jira/browse/HBASE-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061617#comment-13061617
]
stack commented on HBASE-4054:
------------------------------
Patch looks great. I think this new form better than previous where we added a
new class. I'll fix the usage doc (talks about put to return the table to the
pool... when you want them to call close instead) and then commit.
For the future Daniel, bulk of your patch are gratuitous changes of the type
below:
{code}
- * Get a reference to the specified table from the pool.<p>
- *
- * Create a new one if one is not available.
- * @param tableName table name
+ * Get a reference to the specified table from the pool.
+ * <p>
+ * <p/>
+ *
+ * @param tableName
+ * table name
{code}
i.e. no change of substance, just change in formatting. Leave these out of
your patches going forward I'd say.
> Usability improvement to HTablePool
> -----------------------------------
>
> Key: HBASE-4054
> URL: https://issues.apache.org/jira/browse/HBASE-4054
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.3
> Reporter: Daniel Iancu
> Priority: Minor
> Attachments:
> HBASE-4054_Usability_improvement_to_HTablePool-trunk.patch,
> HBASE-4054_Usability_improvement_to_HTablePool.patch
>
>
> To improve the usability of the HTablePool the implementation should not rely
> on the user returning the connection to the pool but rather do that
> transparently when user closes the HTableImplementation it got.
>
> To do that a HTableImplementation proxy implementation should be returned
> that wraps a HTable object and holds a reference to the pool. When the client
> close the proxy it will actually automatically return the wrapped HTable back
> in pool to be reused. In this case the method HTablePool.putTable don't need
> to be public
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
