[
https://issues.apache.org/jira/browse/HBASE-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869245#comment-13869245
]
Hadoop QA commented on HBASE-10324:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622563/HBASE-10324-trunk_v1.patch
against trunk revision .
ATTACHMENT ID: 12622563
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
htd.setAsyncLogFlush(JBoolean.valueOf(arg.delete(DEFERRED_LOG_FLUSH))) if
arg[DEFERRED_LOG_FLUSH]
+ htd.setAsyncLogFlush(JBoolean.valueOf(arg.delete(DEFERRED_LOG_FLUSH)))
if arg[DEFERRED_LOG_FLUSH]
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.TestHeapSize
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8396//console
This message is automatically generated.
> refactor deferred-log-flush/Durability related interface/code/naming to align
> with changed semantic of the new write thread model
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-10324
> URL: https://issues.apache.org/jira/browse/HBASE-10324
> Project: HBase
> Issue Type: Improvement
> Components: Client, regionserver
> Reporter: Feng Honghua
> Assignee: Feng Honghua
> Attachments: HBASE-10324-trunk_v0.patch, HBASE-10324-trunk_v1.patch,
> HBASE-10324-trunk_v2.patch
>
>
> By the new write thread model introduced by
> [HBASE-8755|https://issues.apache.org/jira/browse/HBASE-8755], some
> deferred-log-flush/Durability API/code/names should be change accordingly:
> 1. no timer-triggered deferred-log-flush since flush is always done by async
> threads, so configuration 'hbase.regionserver.optionallogflushinterval' is no
> longer needed
> 2. the async writer-syncer-notifier threads will always be triggered
> implicitly, this semantic is that it always holds that
> 'hbase.regionserver.optionallogflushinterval' > 0, so deferredLogSyncDisabled
> in HRegion.java which affects durability behavior should always be false
> 3. what HTableDescriptor.isDeferredLogFlush really means is the write can
> return without waiting for the sync is done, so the interface name should be
> changed to isAsyncLogFlush/setAsyncLogFlush to reflect their real meaning
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
