[ 
https://issues.apache.org/jira/browse/HBASE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869314#comment-13869314
 ] 

ramkrishna.s.vasudevan commented on HBASE-10321:
------------------------------------------------

Considering this as a blocker, my point was with 0.98 focussing on tags and its 
usages like ACL and Visibility labels, we should not rather do this but handle 
it in case where a 0.96 client tries to talk with 0.98 with Cell Codec throw 
Exception as a codec in 0.98 without tag support sounds weird..  Anoop thinks 
that is not the case as it may affect existing clients if in case they use 
CellCodec (which is rare again).
Or can we just add an api in the CellCodec and do an instance of Cellcodec 
check, and ensure that we don't read the Tag part on the server side?



> CellCodec has broken the 96 client to 98 server compatibility
> -------------------------------------------------------------
>
>                 Key: HBASE-10321
>                 URL: https://issues.apache.org/jira/browse/HBASE-10321
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10321.patch
>
>
> The write/read tags added in CellCodec has broken the 96 client to 98 server 
> compatibility (and 98 client to 96 server)
> When 96 client CellCodec writes cell, it won't write tags part at all. But 
> the server expects a tag part, at least a 0 tag length. This tag length read 
> will make a read of some bytes from next cell!
> I suggest we can remove the tag part from CellCodec. This codec is not used 
> by default and I don't think some one will change to CellCodec from the 
> default KVCodec now. ..
> This makes tags not supported via CellCodec..Tag support can be added to 
> CellCodec once we have Connection negotiation in place (?)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to