[
https://issues.apache.org/jira/browse/HBASE-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869370#comment-13869370
]
chendihao commented on HBASE-10282:
-----------------------------------
The function {{killCurrentActiveZooKeeperServer()}} and
{{killOneBackupZooKeeperServer()}} are nonsense because of this. I think
[~liyin] treated the first zk server as the leader but we can't make sure of
that. So should we rename {{activeZKServerIndex}} into {{firstZKServerIndex}}
and combining these two functions into {{killFirstZooKeeperServer()}}(hard to
know which one is actual leader)?
Need more people to discuss it. [~enis] [~stack]
> We can't assure that the first ZK server is active server in
> MiniZooKeeperCluster
> ---------------------------------------------------------------------------------
>
> Key: HBASE-10282
> URL: https://issues.apache.org/jira/browse/HBASE-10282
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3
> Reporter: chendihao
> Priority: Minor
>
> Thanks to HBASE-3052, we're able to run multiple zk servers in minicluster.
> However, It's confusing to keep the variable activeZKServerIndex as zero and
> assure the first zk server is always the active one. I think returning the
> first sever's client port is for testing and it seems that we can directly
> return the first item of the list. Anyway, the concept of "active" here is
> not the same as zk's.
> It's confusing when I read the code so I think we should fix it.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
