[ 
https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870915#comment-13870915
 ] 

stack commented on HBASE-10336:
-------------------------------

Patch looks good [~echarles].  Thanks.

In here:

+    builder.setName(name).addEndpoint(URI.create("http://"; + bindAddress + ":" 
+ port))

Could we pass "//" instead of "http://"; so it works for both http and https if 
configured?

Will this break h2 and h1 if it gets committed?

Thanks.

> Remove deprecated usage of Hadoop HttpServer in InfoServer
> ----------------------------------------------------------
>
>                 Key: HBASE-10336
>                 URL: https://issues.apache.org/jira/browse/HBASE-10336
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0
>            Reporter: Eric Charles
>         Attachments: HBASE-10336-1.patch, HBASE-10336-2.patch
>
>
> Recent changes in Hadoop HttpServer give NPE when running on hadoop 
> 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be 
> not fixed (see HDFS-5760). We'd better move to the new proposed builder 
> pattern, which means we can no more use inheritance to build our nice 
> InfoServer.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to