[ 
https://issues.apache.org/jira/browse/HBASE-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879322#comment-13879322
 ] 

Hadoop QA commented on HBASE-10401:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12624420/hbase-10401.10400.patch
  against trunk revision .
  ATTACHMENT ID: 12624420

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  protected ExecutorService executor; // threads to retrieve data from 
regionservers, and handle region merges.
+        LOG.warn("[" + thread + "] HDFS region dir " + 
contained.getHdfsRegionDir() + " is missing. " +
+        LOG.warn("[" + thread + "] HDFS region dir " + 
contained.getHdfsRegionDir() + " already sidelined.");

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to 
fail.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8500//console

This message is automatically generated.

> [hbck] perform overlap group merges in parallel
> -----------------------------------------------
>
>                 Key: HBASE-10401
>                 URL: https://issues.apache.org/jira/browse/HBASE-10401
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 0.92.2, 0.98.0, 0.94.16, 0.99.0, 0.96.1.1
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-10401.10400.patch, hbase-10401.patch
>
>
> In a recent support case, we encountered a corrupt hbase that had thousands 
> of "overlap groups" (regions that had overlapping key ranges).  The current 
> implementation repairs these by serially taking a group, perorming a merge 
> and then moving on to the next group.  Because assignments and hdfs nn 
> operations are involved each merge could take on the order of seconds.  With 
> thousands of overlap groups, this could take hours to complete.
> This patch makes it so that these independent merge groups are merged in 
> parallel.  It uses the same thread pool for other fs info-gathering 
> operations.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to