[
https://issues.apache.org/jira/browse/HBASE-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884997#comment-13884997
]
Hudson commented on HBASE-10427:
--------------------------------
SUCCESS: Integrated in HBase-TRUNK #4863 (See
[https://builds.apache.org/job/HBase-TRUNK/4863/])
HBASE-10427 clean up HRegionLocation/ServerName usage (sershe: rev 1562338)
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionLocation.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
*
/hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
*
/hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/CoprocessorHConnection.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
> clean up HRegionLocation/ServerName usage
> ------------------------------------------
>
> Key: HBASE-10427
> URL: https://issues.apache.org/jira/browse/HBASE-10427
> Project: HBase
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Attachments: HBASE-10427.01.patch, HBASE-10427.patch
>
>
> I noticed that AsyncProcess updates cache location on failures using a single
> HRL object that is key to the map that is intended to be by server and
> contains requests for multiple regions (i.e. MultiAction contains requests
> for regions A, B, C, and sits in a map by HRL with HRL from server A as a
> key; in case of failure for e.g. request to B, or entire multiaction, the
> location from map key will be passed to updateCache... methods, even though
> it's not for the correct region). It may cause some subtle mistakes in cache
> updates.
> I think it'd be good to clean up HRL usage around AP and other classes - if
> we intend to have a server name, then we should use ServerName not HRL.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
