[
https://issues.apache.org/jira/browse/HBASE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885074#comment-13885074
]
Hadoop QA commented on HBASE-10436:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625770/hbase-10436.patch
against trunk revision .
ATTACHMENT ID: 12625770
{color:red}-1 @author{color}. The patch appears to contain 1 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8547//console
This message is automatically generated.
> hbase 0.96+ jmx metrics do not have regionserver info any more.
> ---------------------------------------------------------------
>
> Key: HBASE-10436
> URL: https://issues.apache.org/jira/browse/HBASE-10436
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0, 0.96.0, 0.99.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Priority: Critical
> Attachments: hbase-10436.patch
>
>
> HBase 0.96's refactored jmx beans do not contain the master's list of dead
> region servers and live regionservers with load info. HBase 0.94 did (though
> in a single monolithic blob).
> This JMX interface should be considered as much of an API as the the normal
> wire or java api. Dropping values from this was done without deprecation and
> the removal of this information is a functional regression.
> We should provide the information in the 0.96+ JMX. HBase 0.94 had a
> monolithic JMX blob ("hadoop:service=Master,name=Master") that contained a
> lot of information, including the regionserver list and the cached
> regionserver load for each region found on the master webpage. 0.96+
> refactored jmx this into several jmx beans which could be selectively
> retrieved. These include:
> * hadoop:service=HBase,name=Master,sub=AssignmentManager
> * hadoop:service=HBase,name=Master,sub=Balancer
> * hadoop:service=HBase,name=Master,sub=Server
> * hadoop:service=HBase,name=Master,sub=FileSystem
> Specifically the (Hadoop:service=HBase,name=Master,sub=Server) listing that
> used to contain regionservers and deadregionservers in jmx were replaced in
> with numRegionServers and numDeadRegionservers which only contain counts.
> I propose just adding another mbean called "RegionServers" under the bean:
> "hadoop:service=HBase,name=Master,sub=RegionServers"
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
