[
https://issues.apache.org/jira/browse/HBASE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895260#comment-13895260
]
Hadoop QA commented on HBASE-10481:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12627717/HBASE-10481-v1.patch
against trunk revision .
ATTACHMENT ID: 12627717
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+################################################## NOTE ON USAGE
###################################################
+# 1. When using this tool, please specify the initial version first and the
current version second. The semantics
+ echo "JDIFF_WORKING_DIRECTORY not set. That's not an issue. We will default
it to $JDIFF_WORKING_DIRECTORY."
+ echo "When using this tool, please specify the initial version first and
the current version second. They should be in ascending chronological order.
+ The semantics do not make sense otherwise. For example: jdiff 94 95
is good. jdiff 95 94 is bad."
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8634//console
This message is automatically generated.
> API Compatibility JDiff script does not properly handle arguments in reverse
> order
> ----------------------------------------------------------------------------------
>
> Key: HBASE-10481
> URL: https://issues.apache.org/jira/browse/HBASE-10481
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.98.0, 0.94.16, 0.99.0, 0.96.1.1
> Reporter: Aleksandr Shulman
> Assignee: Aleksandr Shulman
> Priority: Minor
> Fix For: 0.94.16, 0.98.1, 0.99.0, 0.96.1.1
>
> Attachments: HBASE-10481-v1.patch
>
>
> [~jmhsieh] found an issue when doing a diff between a pre-0.96 branch and a
> post-0.96 branch.
> Typically, if the pre-0.96 branch is specified first, and the post-0.96
> branch second, the exisitng logic handles it.
> When it is in the reverse order, that logic is not handled properly.
> The fix should address this.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)