[ 
https://issues.apache.org/jira/browse/HBASE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898715#comment-13898715
 ] 

Ted Yu commented on HBASE-10505:
--------------------------------

Thanks for fixing this.
{code}
+   * @param row on which to apply the filter
+   * @return true if the key should not be written, false otherwise
{code}
Please add javadoc for other parameters.

> Import.filterKv does not call Filter.filterRowKey
> -------------------------------------------------
>
>                 Key: HBASE-10505
>                 URL: https://issues.apache.org/jira/browse/HBASE-10505
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 0.98.0, 0.96.2, 0.99.0, 0.94.17
>
>         Attachments: 10505-0.94.txt
>
>
> The general contract of a Filter is that filterRowKey is called before 
> filterKeyValue.
> Import is using Filters for custom filtering but it does not called 
> filterRowKey at all. That throws off some Filters (such as RowFilter, and 
> more recently PrefixFilter, and InclusiveStopFilter). See HBASE-10493 and 
> HBASE-10485.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to