[
https://issues.apache.org/jira/browse/HBASE-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900477#comment-13900477
]
stack commented on HBASE-10525:
-------------------------------
DEATH_PILL smile
Something wrong here N:
+ * We can either write the call directly on the socket, either delegate
this to
+ * a different threads. Ultimately, this will allow to have a set of
writer & reader
+ * for the whole cluster.
+ * Using a different thread allows the client thread to be interrupted w/o
any impact. If
+ * the client threads writes on the sockets, an interruption will close
this socket.
I dont follow the above exactly? On the face of it, yet another thread in
client seems crazy! But your reasoning above seems good
ThreadCallSender should be CallRunner or Call Executor? Or CallNanny Can it
be a static class?
Imlement Closeable since it has a close? Not necessary at all but...
No spaces in here: + setName(name + " - writer");
What will 'name' be?
+ callsToWrite.remove(cts); Do you have to cancel the future itself too?
What happens to outstanding 'calls' when cancel called? How they stopped?
Can you write up a big class comment on the mechanism you are instituting here
so it is clear what is going on both for reviewers and for the folks who come
along afterward trying to make sense of it all. Good on you [~nkeywal]
> Allow the client to use a different thread for writing to ease interrupt
> ------------------------------------------------------------------------
>
> Key: HBASE-10525
> URL: https://issues.apache.org/jira/browse/HBASE-10525
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.99.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.99.0
>
> Attachments: 10525.v1.patch, 10525.v2.patch
>
>
> This is an issue in the HBASE-10070 context, but as well more generally if
> you want to interrupt an operation with a limited cost.
> I will attach a doc with a more detailed explanation.
> This adds a thread per region server; so it's otional. The first patch
> activates it by default to see how it behaves on a full hadoop-qa run. The
> target is to be unset by default.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
