[
https://issues.apache.org/jira/browse/HBASE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901693#comment-13901693
]
Ted Yu commented on HBASE-10451:
--------------------------------
{code}
+ Pair<Integer, Integer> decodedTagsCount =
tagCompressionContext.uncompressTags(
+ currentBuffer, current.tagsBuffer, 0, current.tagsLength);
+ current.decodedTagsCount = decodedTagsCount;
{code}
nit: current.decodedTagsCount can be assigned directly.
{code}
+ * Removes the last entry in the dictionary.
+ * @return the entry, which is just removed
+ */
+ byte[] removeEntry();
{code}
Should the above method come with a better name ? Looking further, head element
is removed.
{code}
+ StoreFileScanner s = reader.getStoreFileScanner(false, false);
{code}
Please close the scanner at the end of the test.
> Enable back Tag compression on HFiles
> -------------------------------------
>
> Key: HBASE-10451
> URL: https://issues.apache.org/jira/browse/HBASE-10451
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Critical
> Fix For: 0.98.1
>
> Attachments: HBASE-10451.patch
>
>
> HBASE-10443 disables tag compression on HFiles. This Jira is to fix the
> issues we have found out in HBASE-10443 and enable it back.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
