[jira] [Commented] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo

[ramkrishna.s.vasudevan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903085#comment-13903085
 ] 

ramkrishna.s.vasudevan commented on HBASE-10531:
------------------------------------------------

Can we just replace the seekTo, reseekTo, seekBefore with an api accepting just 
a Cell and deprecate others.  This would ensure that from the underlying byte 
buffers (what ever format it could be) I could just create a cell from that, it 
may be based on the codec, and create a cell out of it.  Then from the cell 
extract the individuals from that and do the comparison.
{code}
 @Deprecated
  int seekTo(byte[] key) throws IOException;
  @Deprecated
  int seekTo(byte[] key, int offset, int length) throws IOException;

  int seekTo(Cell kv) throws IOException;
{code}
{code}
  @Deprecated
  int reseekTo(byte[] key) throws IOException;
  @Deprecated
  int reseekTo(byte[] key, int offset, int length) throws IOException;

  int reseekTo(Cell kv) throws IOException;
{code}
{code}
 @Deprecated
  boolean seekBefore(byte[] key) throws IOException;
  @Deprecated
  boolean seekBefore(byte[] key, int offset, int length) throws IOException;

  boolean seekBefore(Cell kv) throws IOException;
{code}

> Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
> ------------------------------------------------------------------------
>
>                 Key: HBASE-10531
>                 URL: https://issues.apache.org/jira/browse/HBASE-10531
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>
>
> Currently the byte[] key passed to HFileScanner.seekTo and 
> HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts.  And 
> the caller forms this by using kv.getBuffer, which is actually deprecated.  
> So see how this can be achieved considering kv.getBuffer is removed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)