[ 
https://issues.apache.org/jira/browse/HBASE-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903825#comment-13903825
 ] 

Himanshu Vashishtha commented on HBASE-10563:
---------------------------------------------

With this patch, the stack trace for FlushHandler looks like:
{code}
"MemStoreFlusher.0" prio=10 tid=0x00007f65c862b000 nid=0x20f4 waiting on 
condition [0x00007f65c7af9000]
   java.lang.Thread.State: TIMED_WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x00000000f6939a38> (a 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
        at 
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
        at java.util.concurrent.DelayQueue.poll(DelayQueue.java:201)
        at java.util.concurrent.DelayQueue.poll(DelayQueue.java:39)
        at 
org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:252)
        at java.lang.Thread.run(Thread.java:662)
{code}

The naming is consistent with the other threads (syncers in FSHLog).

mvn test -Dtest=Test*MemStore* passes.

> Set name for FlushHandler thread
> --------------------------------
>
>                 Key: HBASE-10563
>                 URL: https://issues.apache.org/jira/browse/HBASE-10563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.98.0
>            Reporter: Himanshu Vashishtha
>         Attachments: 10563-v1.patch
>
>
> The FlushHandler thread in MemStoreFlusher class uses default thread name 
> (Thread -XX). This is un-intentional and also confusing in case when there 
> are multiple handlers.
> Current Stack trace looks like this:
> {code}
> "Thread-18" prio=10 tid=0x00007f4e8cb21800 nid=0x356e waiting on condition 
> [0x00007f4e6d49a000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
>       at sun.misc.Unsafe.park(Native Method)
>       - parking to wait for  <0x00000004e5684b00> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>       at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
>       at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
>       at java.util.concurrent.DelayQueue.poll(DelayQueue.java:201)
>       at java.util.concurrent.DelayQueue.poll(DelayQueue.java:39)
>       at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:228)
>       at java.lang.Thread.run(Thread.java:662)
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to