[
https://issues.apache.org/jira/browse/HBASE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068513#comment-13068513
]
stack commented on HBASE-4027:
------------------------------
bq. When we catch a block, we throw it into on-heap.
At one point does stuff go into the offheap cache?
bq. I figured since offheap wasn't really in the heap, I didn't include it. Not
sure if this was the best option.
How would an operator monitor offheap if no stats. What should they do? Its
kinda tough because the cache interface only allows return of one 'size'
bq. Apologies for the first few patches.
Don't apologize. This back and forth is healthy.
Looks like the bulk of my comments above can be addressed by comment in code.
Let us know when you think it ready for new review.
> Enable direct byte buffers LruBlockCache
> ----------------------------------------
>
> Key: HBASE-4027
> URL: https://issues.apache.org/jira/browse/HBASE-4027
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Assignee: Li Pi
> Priority: Minor
> Attachments: slabcachepatch.diff, slabcachepatchv2.diff,
> slabcachepatchv3.1.diff, slabcachepatchv3.2.diff, slabcachepatchv3.diff
>
>
> Java offers the creation of direct byte buffers which are allocated outside
> of the heap.
> They need to be manually free'd, which can be accomplished using an
> documented {{clean}} method.
> The feature will be optional. After implementing, we can benchmark for
> differences in speed and garbage collection observances.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
