[
https://issues.apache.org/jira/browse/HBASE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068648#comment-13068648
]
nkeywal commented on HBASE-4118:
--------------------------------
Sorry for the delay. I will create a proper patch next time. I am going to
execute the tests on your patch on my env and will come back to you, so far it
seems ok for me.
On "We should make a KV#matchingRowAndColumn rather than go in there twice?", I
don't know yet. It seems that multiple optimizations are possible. I am going
to proposethe easiest ones first, and then check what remains.
> method regionserver.MemStore/updateColumnValue: the check for qualifier and
> family is missing in the code
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4118
> URL: https://issues.apache.org/jira/browse/HBASE-4118
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.90.3
> Environment: all
> Reporter: nkeywal
> Priority: Minor
> Attachments: 4118.txt
>
>
> {code}
> [...]
> while (it.hasNext()) {
> KeyValue kv = it.next();
> // if this isnt the row we are interested in, then bail:
> if (!firstKv.matchingColumn(family, qualifier) ||
> !firstKv.matchingRow(kv)) {
> break; // rows dont match, bail.
> }
> [...]
> }
> {code}
> should be replaced by:
> {code}
> // if this isnt the row we are interested in, then bail:
> if (!kv.matchingColumn(family, qualifier) ||
> !firstKv.matchingRow(kv)) {
> break; // rows dont match, bail.
> }
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
