[ 
https://issues.apache.org/jira/browse/HBASE-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068827#comment-13068827
 ] 

stack commented on HBASE-3465:
------------------------------

Looks great AA.

Should we include the test jar?

{code}
+  HADOOPCPPATH=$(append_path "${HADOOPCPPATH}" `ls 
${HADOOP_HOME}/hadoop-core*.jar`)
{code}

Is this right?

{code}
+if [ -d "${HBASE_HOME}/build/native" -o -d "${HBASE_HOME}/lib/native" ]; then
{code}

Is it same thing on left and right side of the -o?

Does it work?  If you set HADOOP_HOME, do we use its hadoop and jars over our 
own?

Good stuff.

> Hbase should use a HADOOP_HOME environment variable if available.
> -----------------------------------------------------------------
>
>                 Key: HBASE-3465
>                 URL: https://issues.apache.org/jira/browse/HBASE-3465
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.0
>            Reporter: Ted Dunning
>            Assignee: Alejandro Abdelnur
>         Attachments: a1-HBASE-3465.patch
>
>
> I have been burned a few times lately while developing code by having the 
> make sure that the hadoop jar in hbase/lib is exactly correct.  In my own 
> deployment, there are actually 3 jars and a native library to keep in sync 
> that hbase shouldn't have to know about explicitly.  A similar problem arises 
> when using stock hbase with CDH3 because of the security patches changing the 
> wire protocol.
> All of these problems could be avoided by not assuming that the hadoop 
> library is in the local directory.  Moreover, I think it might be possible to 
> assemble the distribution such that the compile time hadoop dependency is in 
> a cognate directory to lib and is referenced using a default value for 
> HADOOP_HOME.
> Does anybody have any violent antipathies to such a change?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to