[
https://issues.apache.org/jira/browse/HBASE-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910028#comment-13910028
]
Feng Honghua commented on HBASE-10575:
--------------------------------------
bq.I would probably rename "uninitialize" to "terminate", otherwise looks good
to me.
You meant the refactored 'uninitialize' method? hmmm...IMHO 'uninitialize' is
more accurate than 'terminate' in that it only does cleanup of closing
connection and logging before the containing thread being terminated, this
method itself not directly terminates the replication thread, and actually
there is *already* a terminate method which is used by ReplicationManager to
terminate a replication thread from outside.
> ReplicationSource thread can't be terminated if it runs into the loop to
> contact peer's zk ensemble and fails continuously
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-10575
> URL: https://issues.apache.org/jira/browse/HBASE-10575
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 0.98.1, 0.99.0, 0.94.17
> Reporter: Feng Honghua
> Assignee: Feng Honghua
> Priority: Critical
> Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.18
>
> Attachments: HBASE-10575-trunk_v1.patch
>
>
> When ReplicationSource thread runs into the loop to contact peer's zk
> ensemble, it doesn't check isActive() before each retry, so if the given
> peer's zk ensemble is not reachable due to some reason, this
> ReplicationSource thread just can't be terminated by outside such as
> removePeer etc.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
