[
https://issues.apache.org/jira/browse/HBASE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912861#comment-13912861
]
Nicolas Liochon commented on HBASE-10606:
-----------------------------------------
bq. My opinion: why include it you don't use it.
I don't use it because I don't test this part :-). I wrote the test on HTable,
and I used the setter there. But anyway, I removed the setter in the last
version.
bq. By all means, let them bubble up! No over-catching.
At the end, I changed my mind and put the throwable back, checking for
Interrupted exception. At least it's 'as before'.
Other comments taken into account as well.
v4 is what i will commit if the tests are green again.
> Bad timeout in RpcRetryingCaller#callWithRetries w/o parameters
> ---------------------------------------------------------------
>
> Key: HBASE-10606
> URL: https://issues.apache.org/jira/browse/HBASE-10606
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.99.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.99.0
>
> Attachments: 10606.v1.patch, 10606.v2.patch, 10606.v4.patch
>
>
> When we call this method w/o parameters, we don't take into account the
> configuration, but use the hardcoded default (Integer.MAX).
> If someone was relying on having an infinite timeout whatever the setting,
> fixing this bug will cause him a surprise. But there is no magic...
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
