[
https://issues.apache.org/jira/browse/HBASE-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913580#comment-13913580
]
Enis Soztutar commented on HBASE-9990:
--------------------------------------
+1.
One nit is:
{code}
+ // We stored the values in the factory instance. This way, constructing
new objects
{code}
stored should be store?
> HTable uses the conf for each "newCaller"
> -----------------------------------------
>
> Key: HBASE-9990
> URL: https://issues.apache.org/jira/browse/HBASE-9990
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.98.0, 0.96.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 0.99.0
>
> Attachments: 9990.v1.patch, 9990.v2.patch
>
>
> You can construct a RpcRetryingCallerFactory, but actually the conf is read
> for each caller creation. Reading the conf is obviously expensive, and a
> profiling session shows it. If we want to sent hundreds of thousands of
> queries per second, we should not do that.
> RpcRetryingCallerFactory.newCaller is called for each get, for example.
> This is not a regression, we have something similar in 0.94.
> On the 0.96, we see the creation of: java.util.regex.Matcher: 15739712b after
> a few thousand calls to "get".
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
