[ 
https://issues.apache.org/jira/browse/HBASE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913806#comment-13913806
 ] 

Jonathan Hsieh commented on HBASE-10622:
----------------------------------------

This is right on the border of needed to be on review board for me.

This is a bit awkwards.  Make it a do .. while loop?
{code}
+      while (true) {
+        try {
+          copyFile(context, inputPath, outputPath);
+          break;
+        } catch (IOException e) {
+          if (++nattempts >= copyRetry) {
+            throw e;
+          }
+          LOG.warn("Failed copy attempt " + nattempts + ". retrying...", e);
+          Thread.sleep(nattempts * copyRetryWait);
+        }
+      }
{code}

nit: The user/group may not *exist* on the 
{code}
+        } catch (IOException e) {
+          LOG.warn("Unable to set the owner/group for file="+ stat.getPath() 
+": "+ e.getMessage());
+          LOG.warn("The user/group may not exists on the destination cluster: 
user=" +
+                   user + " group=" + group);
+          return false;
{code}

> Improve log and Exceptions in Export Snapshot 
> ----------------------------------------------
>
>                 Key: HBASE-10622
>                 URL: https://issues.apache.org/jira/browse/HBASE-10622
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10622-v0.patch
>
>
> from the logs of export snapshot is not really clear what's going on,
> adding some extra information useful to debug, and in some places the real 
> exception can be thrown



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to