[ 
https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-10531:
-------------------------------------------

    Attachment: HBASE-10531_1.patch

My testcase runs are not getting completed due to envrironment issues.  
Attaching a patch to show how this is done.
Infact as I mentioned earlier doing KeyValue.createKeyFromKeyValue(), is doing 
unnecessary byte copies.  We should think of avoiding them. 
Also the comparison should be done between two cells.  The right hand side of 
the cell is generally the keys from the bytebuffer or the index keys. So if we 
can have a constructor that creates a cell from the bytebuffer without doing a 
copy it would be of great help here.  I have not removed the old code path 
still.  Will upload in RB also.

> Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
> ------------------------------------------------------------------------
>
>                 Key: HBASE-10531
>                 URL: https://issues.apache.org/jira/browse/HBASE-10531
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10531.patch, HBASE-10531_1.patch
>
>
> Currently the byte[] key passed to HFileScanner.seekTo and 
> HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts.  And 
> the caller forms this by using kv.getBuffer, which is actually deprecated.  
> So see how this can be achieved considering kv.getBuffer is removed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to