[
https://issues.apache.org/jira/browse/HBASE-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914345#comment-13914345
]
Anoop Sam John commented on HBASE-10627:
----------------------------------------
+1
> A logic mistake in HRegionServer isHealthy
> ------------------------------------------
>
> Key: HBASE-10627
> URL: https://issues.apache.org/jira/browse/HBASE-10627
> Project: HBase
> Issue Type: Bug
> Reporter: Liu Shaohui
> Priority: Minor
> Attachments: HBASE-10627-0.94-v1.diff, HBASE-10627-trunk-v1.diff
>
>
> After visiting the isHealthy in HRegionServer, I think there is a logic
> mistake.
> {code}
> // Verify that all threads are alive
> if (!(leases.isAlive()
> && cacheFlusher.isAlive() && hlogRoller.isAlive()
> && this.compactionChecker.isAlive()) <---- logic wrong here
> && this.periodicFlusher.isAlive()) {
> stop("One or more threads are no longer alive -- stop");
> return false;
> }
> {code}
> which should be
> {code}
> // Verify that all threads are alive
> if (!(leases.isAlive()
> && cacheFlusher.isAlive() && hlogRoller.isAlive()
> && this.compactionChecker.isAlive()
> && this.periodicFlusher.isAlive())) {
> stop("One or more threads are no longer alive -- stop");
> return false;
> }
> {code}
> Please finger out if i am wrong. Thx
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
