[
https://issues.apache.org/jira/browse/HBASE-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916674#comment-13916674
]
Hudson commented on HBASE-10627:
--------------------------------
FAILURE: Integrated in hbase-0.96-hadoop2 #221 (See
[https://builds.apache.org/job/hbase-0.96-hadoop2/221/])
HBASE-10627 A logic mistake in HRegionServer isHealthy (Shaohui) (tedyu: rev
1573015)
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> A logic mistake in HRegionServer isHealthy
> ------------------------------------------
>
> Key: HBASE-10627
> URL: https://issues.apache.org/jira/browse/HBASE-10627
> Project: HBase
> Issue Type: Bug
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Priority: Minor
> Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.18
>
> Attachments: HBASE-10627-0.94-v1.diff, HBASE-10627-trunk-v1.diff
>
>
> After visiting the isHealthy in HRegionServer, I think there is a logic
> mistake.
> {code}
> // Verify that all threads are alive
> if (!(leases.isAlive()
> && cacheFlusher.isAlive() && hlogRoller.isAlive()
> && this.compactionChecker.isAlive()) <---- logic wrong here
> && this.periodicFlusher.isAlive()) {
> stop("One or more threads are no longer alive -- stop");
> return false;
> }
> {code}
> which should be
> {code}
> // Verify that all threads are alive
> if (!(leases.isAlive()
> && cacheFlusher.isAlive() && hlogRoller.isAlive()
> && this.compactionChecker.isAlive()
> && this.periodicFlusher.isAlive())) {
> stop("One or more threads are no longer alive -- stop");
> return false;
> }
> {code}
> Please finger out if i am wrong. Thx
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
