[ 
https://issues.apache.org/jira/browse/HBASE-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918710#comment-13918710
 ] 

Hadoop QA commented on HBASE-9708:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12632361/HBASE-9708.1.patch
  against trunk revision .
  ATTACHMENT ID: 12632361

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop1.1{color}.  The patch compiles against the hadoop 
1.1 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +      throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" 
+ " qualifier must not be empty");
+                                         "characters': i.e. [a-zA-Z_0-9]: " + 
Bytes.toString(qualifierName));

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/8869//console

This message is automatically generated.

> Improve Snapshot Name Error Message
> -----------------------------------
>
>                 Key: HBASE-9708
>                 URL: https://issues.apache.org/jira/browse/HBASE-9708
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.94.2
>            Reporter: Jesse Anderson
>            Priority: Minor
>         Attachments: HBASE-9708.1.patch, HBASE-9708.1.patch
>
>
> The output for snapshots when you enter an invalid snapshot name talks about 
> "User-space table names" instead of "Snapshot names". The error message 
> should say "Snapshot names can only contain...".
> Here is an example of the output:
> {noformat}
> hbase(main):001:0> snapshot 'user', 'asdf asdf'
> ERROR: java.lang.IllegalArgumentException: Illegal character <32> at 4. 
> User-space table names can only contain 'word characters': i.e. 
> [a-zA-Z_0-9-.]: asdf asdf
> Here is some help for this command:
> Take a snapshot of specified table. Examples:
>   hbase> snapshot 'sourceTable', 'snapshotName'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to