[ 
https://issues.apache.org/jira/browse/HBASE-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921942#comment-13921942
 ] 

Ted Yu commented on HBASE-10620:
--------------------------------

lgtm
nit:
{code}
+    regionReplicaHostCostFunction.init(new Cluster(cs.getClusterState(), 
loads, regionFinder,
+        rackManager));
+    regionReplicaRackCostFunction.init(new Cluster(cs.getClusterState(), 
loads, regionFinder,
+        rackManager));
{code}
The Cluster instance can be shared between regionReplicaHostCostFunction.init() 
and regionReplicaRackCostFunction.init(), right ?

> LoadBalancer.needsBalance() should check for co-located region replicas as 
> well
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-10620
>                 URL: https://issues.apache.org/jira/browse/HBASE-10620
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: 10620-1.txt
>
>
> This is a left over TODO from reviews of HBASE-10351. 
> LB.needsBalance() does some basic checking before running the LB.balance() 
> method. We need to check whether there are co-located regions in this method 
> so that the balancer can increase availability. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to