[
https://issues.apache.org/jira/browse/HBASE-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922965#comment-13922965
]
Devaraj Das commented on HBASE-10355:
-------------------------------------
Looks good overall. Some minor nits (you can fix on commit).
1. Remove the unused import in HRegionServer.java
2. Put a comment in RpcRetryingCallerWithReadReplicas.prepare method on the
scenario when location can be null (the place where you throw HBaseIOE).
I was running the test
mvn clean -Dtest=TestReplicasClient#testGetNoResultStaleRegionWithReplica test
but it seems to hang. Could you please check this.
There are some changes in the patches v3 and v4 to do with the 'stale' setting.
For example, in v3, there were changes in ProtobufUtil.java and in HRegion.java
(look at Footnote below) but in v4 those changes are not present. I went
through some missing changes and they already are present in the branch (some
of them introduced via
https://issues.apache.org/jira/secure/attachment/12628542/10354.add.patch and
the related comment is
https://issues.apache.org/jira/browse/HBASE-10354?focusedCommentId=13899470&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13899470).
Please ensure the necessary changes are all there in the latest patch.
[Footnote - Stack had commented earlier - "Can we avoid HRegion having to know
about 'replicas'?" but it seems the branch already has this change.]
> Failover RPC's from client using region replicas
> ------------------------------------------------
>
> Key: HBASE-10355
> URL: https://issues.apache.org/jira/browse/HBASE-10355
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Reporter: Enis Soztutar
> Assignee: Nicolas Liochon
> Fix For: 0.99.0
>
> Attachments: 10355.v1.patch, 10355.v2.patch, 10355.v3.patch,
> 10355.v4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
