[ 
https://issues.apache.org/jira/browse/HBASE-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922616#comment-13922616
 ] 

Ted Yu edited comment on HBASE-10687 at 3/6/14 10:18 PM:
---------------------------------------------------------

Also the code snippet in section I.2 is not correct. I am assuming that the 
APIs got changed after the write-up in the book. Here is a sample code which 
compiles currently
{code}
                Configuration conf = HBaseConfiguration.create();
                SpanReceiverHost spanReceiverHost = 
SpanReceiverHost.getInstance(conf);
                TraceScope getSpan = Trace.startSpan("Gets", Sampler.ALWAYS);
                try{
                        System.out.println("Is tracing on :"+Trace.isTracing());
                        HTable table = new HTable(conf, "t1"); 
                        Get get = new Get(Bytes.toBytes("r1"));
                        Result res = table.get(get);
                        System.out.println(res.toString());
                        table.close();
                } catch(Exception e) {
                        getSpan.close();
                } finally {
                        getSpan.close();
                }
{code}


was (Author: gsbiju):
Also the code snippet in section I.2 is not correct. I am assuming that the 
APIs got changed after the write-up in the book. Here is a sample code which 
compiles currently

                Configuration conf = HBaseConfiguration.create();
                SpanReceiverHost spanReceiverHost = 
SpanReceiverHost.getInstance(conf);
                TraceScope getSpan = Trace.startSpan("Gets", Sampler.ALWAYS);
                try{
                        System.out.println("Is tracing on :"+Trace.isTracing());
                        HTable table = new HTable(conf, "t1"); 
                        Get get = new Get(Bytes.toBytes("r1"));
                        Result res = table.get(get);
                        System.out.println(res.toString());
                        table.close();
                } catch(Exception e) {
                        getSpan.close();
                } finally {
                        getSpan.close();
                }

> Fix description about HBaseLocalFileSpanReceiver in reference manual
> --------------------------------------------------------------------
>
>                 Key: HBASE-10687
>                 URL: https://issues.apache.org/jira/browse/HBASE-10687
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>         Attachments: HBASE-10687-0.patch
>
>
> There is description about non existent HBaseLocalFileSpanReceiver class in 
> "Appendix I. Enabling Dapper-like Tracing in HBase" of the reference manual.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to