[ 
https://issues.apache.org/jira/browse/HBASE-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931069#comment-13931069
 ] 

Lars Hofhansl commented on HBASE-10722:
---------------------------------------

Thanks Nick.

Hmm... StoreFile.computeRefFileHDFSBlockDistribution is also calling that, and 
doing the right thing (in fact that's where I looked as how it's done 
correctly).
The other place is CompactionInputFormat, and that's also not right (also wrong 
in trunk).
I think FSUtil should stay at the FS level, and not know much about HBase 
specifics. In trunk we have HRegionFileSystem, but not in 0.94. Then again in 
trunk I see stuff like getRegionDegreeLocalityMappingFromFS in FSUtil. What a 
mess.

I think for 0.94 it's best to fix it in HRegion. I would just remove it, but 
coprocessor might call it (and currently get wrong results).


> [0.94] HRegion.computeHDFSBlocksDistribution does not account for links and 
> reference files.
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10722
>                 URL: https://issues.apache.org/jira/browse/HBASE-10722
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.94.18
>
>         Attachments: 10722.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to