[
https://issues.apache.org/jira/browse/HBASE-10749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935116#comment-13935116
]
Hadoop QA commented on HBASE-10749:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634710/HBASE-10749.patch
against trunk revision .
ATTACHMENT ID: 12634710
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8996//console
This message is automatically generated.
> CellComparator.compareStatic() compares type wrongly
> ----------------------------------------------------
>
> Key: HBASE-10749
> URL: https://issues.apache.org/jira/browse/HBASE-10749
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.1, 0.99.0, 0.96.1.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.98.1, 0.99.0
>
> Attachments: HBASE-10749.patch
>
>
> CellComparator.compareStatic(Cell a, Cell b) compares type wrongly.
> {code}
> //type
> c = (0xff & a.getTypeByte()) - (0xff & b.getTypeByte());
> if (c != 0) return c;
> {code}
> In the normal case it should be the other way
> {code}
> // Compare types. Let the delete types sort ahead of puts; i.e. types
> // of higher numbers sort before those of lesser numbers. Maximum (255)
> // appears ahead of everything, and minimum (0) appears after
> // everything.
> return (0xff & rtype) - (0xff & ltype);
> {code}
> Found this issue while replacing KVComparator to use CellComparator.
> [~mcorgan]
> Could you confirm this once? Currently PrefixTree code path uses this
> compareStatic method.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
