[ 
https://issues.apache.org/jira/browse/HBASE-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935592#comment-13935592
 ] 

Ted Yu commented on HBASE-7847:
-------------------------------

lgtm
{code}
+   * @throws KeeperException
+   */
+  public static void 
deleteChildrenRecursivelyMultiOrSequential(ZooKeeperWatcher zkw,
{code}
Please add javadoc for the above method.
{code}
+      // enables back the multi-update api execution
+      zkw.getConfiguration().setBoolean("hbase.zookeeper.useMulti", true);
{code}
Should the current config value be saved at beginning of test and restored in 
finally ?

> Use zookeeper multi to clear znodes
> -----------------------------------
>
>                 Key: HBASE-7847
>                 URL: https://issues.apache.org/jira/browse/HBASE-7847
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>         Attachments: 7847-v1.txt, HBASE-7847.patch, HBASE-7847.patch, 
> HBASE-7847.patch, HBASE-7847_v4.patch
>
>
> In ZKProcedureUtil, clearChildZNodes() and clearZNodes(String procedureName) 
> should utilize zookeeper multi so that they're atomic



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to