[ 
https://issues.apache.org/jira/browse/HBASE-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937482#comment-13937482
 ] 

Victor Xu commented on HBASE-10760:
-----------------------------------

Yes, this exchange is a VERY small literal modification. It doesn't affect the 
implementation logic. That's why I set the priority to 'Minor'.
I found this issue when I tried to understand the logic in SimpleLoadBalancer 
several days ago. At that time, the wrong names of the methods confused me a 
lot. But after testing, I found the actual logic are totally the opposite from 
their names. So I submitted this patch, preventing others from be confused by 
the code again:)

> Wrong methods' names in ClusterLoadState class
> ----------------------------------------------
>
>                 Key: HBASE-10760
>                 URL: https://issues.apache.org/jira/browse/HBASE-10760
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer
>    Affects Versions: 0.98.0
>            Reporter: Victor Xu
>            Assignee: Victor Xu
>            Priority: Minor
>             Fix For: 0.96.2, 0.98.1, 0.99.0
>
>         Attachments: HBASE_10760.patch, HBASE_10760_V2.patch
>
>
> In ClusterLoadState class, there are two methods using the wrong names: 
> getMaxLoad() and getMinLoad(). However, the implementation of the two methods 
> are right, so just exchange them.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to