[
https://issues.apache.org/jira/browse/HBASE-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937615#comment-13937615
]
Hadoop QA commented on HBASE-10766:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635046/HBASE-10766-v2.patch
against trunk revision .
ATTACHMENT ID: 12635046
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9024//console
This message is automatically generated.
> SnapshotCleaner allows to delete referenced files
> -------------------------------------------------
>
> Key: HBASE-10766
> URL: https://issues.apache.org/jira/browse/HBASE-10766
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 0.98.0, 0.96.1.1, 0.94.17
> Reporter: Matteo Bertozzi
> Assignee: bharath v
> Fix For: 0.96.2, 0.94.18, 0.98.2
>
> Attachments: HBASE-10766-v1.patch, HBASE-10766-v2.patch
>
>
> The SnapshotFileCache is checking the lastModificationTime() of the
> ".hbase-snapshot" directory.
> But in this way "pending" snapshots created in temp are not considered.
> since only the parent directory timestamp is updated.
> so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification
> timestamp of .hbase-snapshot will not be updated
> https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197
--
This message was sent by Atlassian JIRA
(v6.2#6252)
