[jira] [Commented] (HBASE-10780) HFilePrettyPrinter#processFile should return immediately if file does not exists.

[Ashish Singhi (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938834#comment-13938834
 ] 

Ashish Singhi commented on HBASE-10780:
---------------------------------------

Should we exit with non zero exit code on any IOE ? Currently on any IOE we 
just log and command exit code is 0.
{code}
      try {
        processFile(fileName);
      } catch (IOException ex) {
        LOG.error("Error reading " + fileName, ex);
      }
{code}


> HFilePrettyPrinter#processFile should return immediately if file does not 
> exists.
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-10780
>                 URL: https://issues.apache.org/jira/browse/HBASE-10780
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 0.94.11
>            Reporter: Ashish Singhi
>            Priority: Minor
>         Attachments: HBASE-10780.patch
>
>
> HFilePrettyPrinter#processFile should return immediately if file does not 
> exists same like HLogPrettyPrinter#run
> {code}
>     if (!fs.exists(file)) {
>       System.err.println("ERROR, file doesnt exist: " + file);
>     }{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)