[
https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated HBASE-10531:
-------------------------------------------
Attachment: HBASE-10531_7.patch
Updated patch. Addresses the review comments. Fixes long lines and testcase
passes with this.
Stack had a point saying this patch may slow down in the read path as we are
now changing a simple byte[] comparison to creating an object and then
comparing. But to have cells in the read path we need to go in phases. When I
tried to change everywhere to cells the changes were big and difficult to
follow. After this patch if we are able to change the DBE to work with Cells
then we will be in a better shape to work with Cells. Also the comparators
needs to be changed.
> Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
> ------------------------------------------------------------------------
>
> Key: HBASE-10531
> URL: https://issues.apache.org/jira/browse/HBASE-10531
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10531.patch, HBASE-10531_1.patch,
> HBASE-10531_2.patch, HBASE-10531_3.patch, HBASE-10531_4.patch,
> HBASE-10531_5.patch, HBASE-10531_6.patch, HBASE-10531_7.patch
>
>
> Currently the byte[] key passed to HFileScanner.seekTo and
> HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts. And
> the caller forms this by using kv.getBuffer, which is actually deprecated.
> So see how this can be achieved considering kv.getBuffer is removed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
