[ 
https://issues.apache.org/jira/browse/HBASE-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946021#comment-13946021
 ] 

Ted Yu commented on HBASE-10818:
--------------------------------

Looks good overall.
{code}
+    } catch (InterruptedException e) {
+      throw (InterruptedIOException) new InterruptedException().initCause(e);
{code}
The above maybe a typo: new InterruptedException -> new InterruptedIOException
There are more than one place where the above appears.
{code}
+    Scan scan = new Scan();
+    scan.addFamily(CHAIN_FAM);
+    scan.addFamily(SORT_FAM);
+    scan.setMaxVersions(1);
{code}
nit: you can chain the above calls since Scan object is returned.
{code}
+      } else {
+        LOG.debug("All regions updated.");
+      }
{code}
Was a 'break' missing from the else block ?

> Add integration test for bulkload with replicas
> -----------------------------------------------
>
>                 Key: HBASE-10818
>                 URL: https://issues.apache.org/jira/browse/HBASE-10818
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: hbase-10070
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: HBASE-10818.00.patch, HBASE-10818.01.patch, 
> IntegrationTestBulkLoad_replicas.log
>
>
> Should verify bulkload is not affected by region replicas.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to