[
https://issues.apache.org/jira/browse/HBASE-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946689#comment-13946689
]
Nicolas Liochon commented on HBASE-10817:
-----------------------------------------
bq. This looks similar to the Coproc in TestReplicasClient. Maybe there's some
reuse between them, or a shared library of coprocs for tests?
It's totally similar :-)
But it's always difficult to share code between tests.
bq. nit: Should just use the constant
done.
bq. Better to add some kind of max iteration count here to protect our poor
jenkins box from itself.
Agreed. I added Waiter.waitFor
bq. disableTable and enableTable are both synchronous, but modifyTable is
asynchronous
I'm not sure that modifyTable is really asynchronous (despite the doc): we
release the lock synchronously, so I expect it will work. I think that we have
an issue if it does not.
v3 on his way.
> Add some tests on a real cluster for replica: multi master, replication
> -----------------------------------------------------------------------
>
> Key: HBASE-10817
> URL: https://issues.apache.org/jira/browse/HBASE-10817
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver, Replication
> Affects Versions: hbase-10070
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Priority: Minor
> Fix For: hbase-10070
>
> Attachments: 10817.v1.patch, 10817.v2.patch, 10817.v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
