[ 
https://issues.apache.org/jira/browse/HBASE-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-10818:
---------------------------------

    Attachment: HBASE-10818.02.patch

Attaching new patch that addresses all but the final review comment.

bq. The above maybe a typo: new InterruptedException -> new 
InterruptedIOException

These are removed, instead the methods throw InterruptedExceptions.

bq. you can chain the above calls since Scan object is returned.

And yet {{setCacheBlocks}} and {{setBatch}} don't. Should file a separate 
ticket to fix that API bug.

bq. Was a 'break' missing from the else block ?

My understanding is the loop condition will break execution immediately 
thereafter. I'll add a break just the same, it should make the intent more 
obvious to a reader.

bq. You should set the sleepTime in SlowMeCopro to something like 10 seconds. 
It defaults to 0.

This is tricky. There isn't a way to modify the state of that coproc on a real 
cluster. Maybe an endpoint could be added?

> Add integration test for bulkload with replicas
> -----------------------------------------------
>
>                 Key: HBASE-10818
>                 URL: https://issues.apache.org/jira/browse/HBASE-10818
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: hbase-10070
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: HBASE-10818.00.patch, HBASE-10818.01.patch, 
> HBASE-10818.02.patch, IntegrationTestBulkLoad_replicas.log
>
>
> Should verify bulkload is not affected by region replicas.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to