[ 
https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948242#comment-13948242
 ] 

Nick Dimiduk commented on HBASE-10788:
--------------------------------------

nit: this patch has some extra ws. Please clean it up on commit.

The thread name is not relevant in MR mode, and is redundant in your example 
output above.

{noformat}
+      String metricName =
+          testName + "-Client-" + Thread.currentThread().getName() + 
"-testRowTime";
{noformat}

This will inaccurately count any results from tests that respect --sampleRate.

{noformat}
+        long startTime = System.currentTimeMillis();
         testRow(i);
+        latency.update(System.currentTimeMillis() - startTime);
{noformat}

> Add 99th percentile of latency in PE
> ------------------------------------
>
>                 Key: HBASE-10788
>                 URL: https://issues.apache.org/jira/browse/HBASE-10788
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.99.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff
>
>
> In production env, 99th percentile of latency is more important than the avg. 
> The 99th percentile is helpful to measure the influence of GC, slow 
> read/write of HDFS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to