[
https://issues.apache.org/jira/browse/HBASE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073087#comment-13073087
]
[email protected] commented on HBASE-4027:
------------------------------------------------------
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > conf/hbase-env.sh, line 42
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28356#file28356line42>
bq. >
bq. > Extra whitespace is obvious on review board.
Fixed.
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheTestUtils.java,
line 2
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28358#file28358line2>
bq. >
bq. > Year of copyright.
Fixed.
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheTestUtils.java,
line 48
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28358#file28358line48>
bq. >
bq. > Long line should wrap.
Fixed.
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheTestUtils.java,
line 64
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28358#file28358line64>
bq. >
bq. > Indentation should be corrected for the if block.
Fixed
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java, line 2
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28359#file28359line2>
bq. >
bq. > Copyright missing.
Fixed
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java, line 25
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28359#file28359line25>
bq. >
bq. > This implies that an eviction may involve fewer than one block.
bq. > If so, this count can be named evictedBlockCount.
Fixed.
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java,
line 100
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28360#file28360line100>
bq. >
bq. > Should we add hitCount for offHeapCache ?
bq. > This can be addressed in a follow-on JIRA.
I think the offHeapCache should have a hitcount, but we can deal with it later.
Right now, it has the full CacheStats metrics.
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java,
line 115
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28360#file28360line115>
bq. >
bq. > In a follow-on JIRA, we can distinguish between onHeap eviction and
offHeap eviction counts.
Agreed. I may be redoing this substantially in a follow on Jira.
bq. On 2011-07-29 05:14:48, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java,
line 145
bq. > <https://reviews.apache.org/r/1214/diff/2/?file=28360#file28360line145>
bq. >
bq. > Is this a typo ?
Yup, and fixed.
- Li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1214/#review1220
-----------------------------------------------------------
On 2011-07-28 23:02:50, Li Pi wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1214/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-28 23:02:50)
bq.
bq.
bq. Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, Jonathan
Gray, and Li Pi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review request - I apparently can't edit tlipcon's earlier posting of my
diff, so creating a new one.
bq.
bq.
bq. This addresses bug HBase-4027.
bq. https://issues.apache.org/jira/browse/HBase-4027
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. conf/hbase-env.sh 2d55d27
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 509121d
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheTestUtils.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
ecab7ca
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
150f54f
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
PRE-CREATION
bq.
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1d5e3fa
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
b600020
bq.
src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSlabCache.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlab.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1214/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran benchmarks against it in HBase standalone mode. Wrote test cases for
all classes, multithreaded test cases exist for the cache.
bq.
bq.
bq. Thanks,
bq.
bq. Li
bq.
bq.
> Enable direct byte buffers LruBlockCache
> ----------------------------------------
>
> Key: HBASE-4027
> URL: https://issues.apache.org/jira/browse/HBASE-4027
> Project: HBase
> Issue Type: Improvement
> Reporter: Jason Rutherglen
> Assignee: Li Pi
> Priority: Minor
> Attachments: 4027-v5.diff, HBase-4027.pdf, hbase-4027v6.diff,
> slabcachepatch.diff, slabcachepatchv2.diff, slabcachepatchv3.1.diff,
> slabcachepatchv3.2.diff, slabcachepatchv3.diff, slabcachepatchv4.5.diff,
> slabcachepatchv4.diff
>
>
> Java offers the creation of direct byte buffers which are allocated outside
> of the heap.
> They need to be manually free'd, which can be accomplished using an
> documented {{clean}} method.
> The feature will be optional. After implementing, we can benchmark for
> differences in speed and garbage collection observances.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
