[
https://issues.apache.org/jira/browse/HBASE-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956466#comment-13956466
]
Hadoop QA commented on HBASE-10881:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12638043/HBASE-10881-trunk-v2.diff
against trunk revision .
ATTACHMENT ID: 12638043
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static final org.apache.thrift.protocol.TField
REVERSED_FIELD_DESC = new org.apache.thrift.protocol.TField("reversed",
org.apache.thrift.protocol.TType.BOOL, (short)9);
+ private _Fields optionals[] =
{_Fields.START_ROW,_Fields.STOP_ROW,_Fields.TIMESTAMP,_Fields.COLUMNS,_Fields.CACHING,_Fields.FILTER_STRING,_Fields.BATCH_SIZE,_Fields.SORT_COLUMNS,_Fields.REVERSED};
+ tmpMap.put(_Fields.REVERSED, new
org.apache.thrift.meta_data.FieldMetaData("reversed",
org.apache.thrift.TFieldRequirementType.OPTIONAL,
+ private static final org.apache.thrift.protocol.TField REVERSED_FIELD_DESC =
new org.apache.thrift.protocol.TField("reversed",
org.apache.thrift.protocol.TType.BOOL, (short)11);
+ private _Fields optionals[] =
{_Fields.START_ROW,_Fields.STOP_ROW,_Fields.COLUMNS,_Fields.CACHING,_Fields.MAX_VERSIONS,_Fields.TIME_RANGE,_Fields.FILTER_STRING,_Fields.BATCH_SIZE,_Fields.ATTRIBUTES,_Fields.AUTHORIZATIONS,_Fields.REVERSED};
+ tmpMap.put(_Fields.REVERSED, new
org.apache.thrift.meta_data.FieldMetaData("reversed",
org.apache.thrift.TFieldRequirementType.OPTIONAL,
+ org.apache.thrift.protocol.TList _list117 = new
org.apache.thrift.protocol.TList(org.apache.thrift.protocol.TType.STRUCT,
iprot.readI32());
+ org.apache.thrift.protocol.TMap _map120 = new
org.apache.thrift.protocol.TMap(org.apache.thrift.protocol.TType.STRING,
org.apache.thrift.protocol.TType.STRING, iprot.readI32());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9156//console
This message is automatically generated.
> Support reverse scan in thrift2
> -------------------------------
>
> Key: HBASE-10881
> URL: https://issues.apache.org/jira/browse/HBASE-10881
> Project: HBase
> Issue Type: New Feature
> Components: Thrift
> Affects Versions: 0.99.0
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-10881-trunk-v1.diff, HBASE-10881-trunk-v2.diff
>
>
> Support reverse scan in thrift2.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
