[ 
https://issues.apache.org/jira/browse/HBASE-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960916#comment-13960916
 ] 

Alex Baranau commented on HBASE-6618:
-------------------------------------

[~kuzmiigo] 

bq. I thought that the value in the fixed part is checked as whole, but the 
code actually checks its bytes in isolation, so the rule is actually ????0(0 - 
9)(0 - 9)(1 - 9)

not true. aa68 will satisfy the rule ??(53 - 97). Added a test specifically for 
that:

{code}
    // Range
    Assert.assertEquals(FuzzyRowFilter.SatisfiesCode.YES,
                        FuzzyRowFilter.satisfies(
                          new byte[]{1, 1, 6, 8},
                          new Triple<byte[], byte[], byte[]>(
                            new byte[]{0, 0, 1, 1}, // mask
                            new byte[]{1, 1, 5, 6}, // upper bytes
                            new byte[]{1, 1, 9, 7}))); // lower bytes
{code}

> Implement FuzzyRowFilter with ranges support
> --------------------------------------------
>
>                 Key: HBASE-6618
>                 URL: https://issues.apache.org/jira/browse/HBASE-6618
>             Project: HBase
>          Issue Type: New Feature
>          Components: Filters
>            Reporter: Alex Baranau
>            Assignee: Alex Baranau
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: HBASE-6618-algo-desc-bits.png, HBASE-6618-algo.patch, 
> HBASE-6618.patch, HBASE-6618_2.path, HBASE-6618_3.path
>
>
> Apart from current ability to specify fuzzy row filter e.g. for 
> <userId_actionId> format as ????_0004 (where 0004 - actionId) it would be 
> great to also have ability to specify the "fuzzy range" , e.g. ????_0004, 
> ..., ????_0099.
> See initial discussion here: http://search-hadoop.com/m/WVLJdX0Z65
> Note: currently it is possible to provide multiple fuzzy row rules to 
> existing FuzzyRowFilter, but in case when the range is big (contains 
> thousands of values) it is not efficient.
> Filter should perform efficient fast-forwarding during the scan (this is what 
> distinguishes it from regex row filter).
> While such functionality may seem like a proper fit for custom filter (i.e. 
> not including into standard filter set) it looks like the filter may be very 
> re-useable. We may judge based on the implementation that will hopefully be 
> added.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to