[ 
https://issues.apache.org/jira/browse/HBASE-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963398#comment-13963398
 ] 

Jimmy Xiang commented on HBASE-10922:
-------------------------------------

Cool. Looks good. One question, progress_failed is set to false initially. If 
finishWritingAndClose throws any exception, we will log saying it not failed, 
right? Can we set progress_failed to true initially instead?

I was also wondering if it is good to override progress_failed in the finally 
block. Should we use a different variable instead?  I know this is some 
existing code already there for a while.

> Log splitting status should always be closed
> --------------------------------------------
>
>                 Key: HBASE-10922
>                 URL: https://issues.apache.org/jira/browse/HBASE-10922
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Priority: Minor
>         Attachments: hbase-10922.patch, log-splitting_hang.png, 
> master-log-grep.txt, master.log.gz
>
>
> With distributed log replay enabled by default, I ran into an issue that log 
> splitting hasn't completed after 13 hours. It seems to hang somewhere.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to