[
https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964955#comment-13964955
]
Hadoop QA commented on HBASE-10884:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639497/HBASE-10884.patch
against trunk revision .
ATTACHMENT ID: 12639497
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//console
This message is automatically generated.
> [REST] Do not disable block caching when scanning
> -------------------------------------------------
>
> Key: HBASE-10884
> URL: https://issues.apache.org/jira/browse/HBASE-10884
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.98.1, 0.96.1.1, 0.94.18
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Attachments: HBASE-10884.patch
>
>
> The REST gateway pessimistically disables block caching when issuing Scans to
> the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It
> does not do this when issuing Gets on behalf of HTTP clients in
> RowResultGenerator. This is an old idea now, the reasons for doing so lost
> sometime back in the era when HBase walked the earth with dinosaurs (< 0.20).
> We probably should not be penalizing REST scans in this way.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
