[ 
https://issues.apache.org/jira/browse/HBASE-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967329#comment-13967329
 ] 

Hadoop QA commented on HBASE-10966:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12639885/HBASE-10966-1.patch
  against trunk revision .
  ATTACHMENT ID: 12639885

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9264//console

This message is automatically generated.

> RowCounter misinterprets column names that have colons in their qualifier
> -------------------------------------------------------------------------
>
>                 Key: HBASE-10966
>                 URL: https://issues.apache.org/jira/browse/HBASE-10966
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0
>            Reporter: Alexandre Normand
>            Assignee: Alexandre Normand
>            Priority: Trivial
>         Attachments: HBASE-10966-1.patch
>
>
> RowCounter allows for column names to be specify at command line:
> {code}
> Usage: RowCounter [options] <tablename> [--range=[startKey],[endKey]] 
> [<column1> <column2>...]
> For performance consider the following options:
> -Dhbase.client.scanner.caching=100
> -Dmapred.map.tasks.speculative.execution=false
> {code}
> However, the column names are parsed assuming that if there is a colon, there 
> are only two parts to the string. In other words, it assumes 
> {{family:qualifier}} where {{qualifier}} wouldn't contain a colon. 
> This came up as I was trying to do a row count on a {{kiji}} table where 
> qualifiers typically have multiple colon-delimited components (i.e. {{B:C}} 
> could be a qualifier in the {{B}} family).
> The flaw is in this code:
> {code}
>        String  [] fields = columnName.split(":");
>         if(fields.length == 1) {
>           scan.addFamily(Bytes.toBytes(fields[0]));
>         } else {
>           byte[] qualifier = Bytes.toBytes(fields[1]);
>           qualifiers.add(qualifier);
>           scan.addColumn(Bytes.toBytes(fields[0]), qualifier); 
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to