[
https://issues.apache.org/jira/browse/HBASE-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967387#comment-13967387
]
Ted Yu commented on HBASE-10965:
--------------------------------
The filter referenced in above code is of FilterWrapper where hasFilterRow()
uses the return value from isFilterMethodImplemented().
bq. Also we rely on this hasFilterRow() in other places too.
I searched all references to hasFilterRow() and made corresponding changes.
Filter#hasFilterRow() can now be deprecated.
bq. Why is the change in FilterList
This is to make hasFilterRow() consistent with the filterRow() method. Prior to
this change, filterRow() iterates through filters and calls filterRow(). So the
change is consistent with the description of Filter#hasFilterRow().
> Automate detection of presence of Filter#filterRow()
> ----------------------------------------------------
>
> Key: HBASE-10965
> URL: https://issues.apache.org/jira/browse/HBASE-10965
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 10965-v1.txt, 10965-v2.txt
>
>
> There is potential inconsistency between the return value of
> Filter#hasFilterRow() and presence of Filter#filterRow().
> Filters may override Filter#filterRow() while leaving return value of
> Filter#hasFilterRow() being false (inherited from FilterBase).
> This JIRA aims to remove the inconsistency by automatically detecting the
> presence of overridden Filter#filterRow().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
