[ 
https://issues.apache.org/jira/browse/HBASE-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967444#comment-13967444
 ] 

Hudson commented on HBASE-10968:
--------------------------------

SUCCESS: Integrated in HBase-TRUNK #5080 (See 
[https://builds.apache.org/job/HBase-TRUNK/5080/])
HBASE-10968 Null check in 
TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize() is 
redundant (tedyu: rev 1586806)
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormat.java


> Null check in 
> TableSnapshotInputFormat#TableSnapshotRegionRecordReader#initialize() is 
> redundant
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10968
>                 URL: https://issues.apache.org/jira/browse/HBASE-10968
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 10968-v1.txt
>
>
> Here is related code:
> {code}
>     public void initialize(InputSplit split, TaskAttemptContext context) 
> throws IOException,
>         InterruptedException {
>       Configuration conf = context.getConfiguration();
> ...
>       if (context != null) {
>         this.context = context;
>         getCounter = 
> TableRecordReaderImpl.retrieveGetCounterWithStringsParams(context);
>       }
> {code}
> context was dereferenced first, leaving the null check ineffective.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to